lkml.org 
[lkml]   [2017]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 097/133] bcache: Fix leak of bdev reference
    3.16.51-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jan Kara <jack@suse.cz>

    commit 4b758df21ee7081ab41448d21d60367efaa625b3 upstream.

    If blkdev_get_by_path() in register_bcache() fails, we try to lookup the
    block device using lookup_bdev() to detect which situation we are in to
    properly report error. However we never drop the reference returned to
    us from lookup_bdev(). Fix that.

    Signed-off-by: Jan Kara <jack@suse.cz>
    Acked-by: Coly Li <colyli@suse.de>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/md/bcache/super.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/md/bcache/super.c
    +++ b/drivers/md/bcache/super.c
    @@ -1974,6 +1974,8 @@ static ssize_t register_bcache(struct ko
    else
    err = "device busy";
    mutex_unlock(&bch_register_lock);
    + if (!IS_ERR(bdev))
    + bdput(bdev);
    if (attr == &ksysfs_register_quiet)
    goto out;
    }
    \
     
     \ /
      Last update: 2017-11-22 03:36    [W:3.741 / U:3.936 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site