lkml.org 
[lkml]   [2017]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:x86/urgent] x86/pkeys/selftests: Fix protection keys write() warning
    Commit-ID:  7b659ee3e1fe0e8eb39730afb903c64e25490ec4
    Gitweb: https://git.kernel.org/tip/7b659ee3e1fe0e8eb39730afb903c64e25490ec4
    Author: Dave Hansen <dave.hansen@linux.intel.com>
    AuthorDate: Fri, 10 Nov 2017 16:12:32 -0800
    Committer: Ingo Molnar <mingo@kernel.org>
    CommitDate: Tue, 21 Nov 2017 09:34:52 +0100

    x86/pkeys/selftests: Fix protection keys write() warning

    write() is marked as having a must-check return value. Check it and
    abort if we fail to write an error message from a signal handler.

    Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
    Acked-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Josh Poimboeuf <jpoimboe@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/20171111001232.94813E58@viggo.jf.intel.com
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    ---
    tools/testing/selftests/x86/pkey-helpers.h | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/x86/pkey-helpers.h b/tools/testing/selftests/x86/pkey-helpers.h
    index 3818f25..b3cb767 100644
    --- a/tools/testing/selftests/x86/pkey-helpers.h
    +++ b/tools/testing/selftests/x86/pkey-helpers.h
    @@ -30,6 +30,7 @@ static inline void sigsafe_printf(const char *format, ...)
    if (!dprint_in_signal) {
    vprintf(format, ap);
    } else {
    + int ret;
    int len = vsnprintf(dprint_in_signal_buffer,
    DPRINT_IN_SIGNAL_BUF_SIZE,
    format, ap);
    @@ -39,7 +40,9 @@ static inline void sigsafe_printf(const char *format, ...)
    */
    if (len > DPRINT_IN_SIGNAL_BUF_SIZE)
    len = DPRINT_IN_SIGNAL_BUF_SIZE;
    - write(1, dprint_in_signal_buffer, len);
    + ret = write(1, dprint_in_signal_buffer, len);
    + if (ret < 0)
    + abort();
    }
    va_end(ap);
    }
    \
     
     \ /
      Last update: 2017-11-21 09:47    [W:3.529 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site