lkml.org 
[lkml]   [2017]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting per-thread shadow stats
From
Date


On 11/21/2017 11:17 PM, Jiri Olsa wrote:
> On Mon, Nov 20, 2017 at 10:43:38PM +0800, Jin Yao wrote:
>> In current stat-shadow.c, the rblist deleting is ignored.
>>
>> The patch reconstructs the codes of rblist init/free, and adds
>> the implementation to node_delete method of rblist.
>>
>> This patch also does:
>>
>> 1. Add the ctx/type/stat into rbtree keys because we will
>> use this rbtree to maintain shadow metrics to replace original
>> a couple of static arrays for supporting per-thread shadow stats.
>>
>> 2. Create a static runtime_stat variable 'rt_stat' which
>> will log the shadow metrics by default.
>
> please make that separate patches then,
> one patch - one logical change
>
> thanks,
> jirka
>

OK, I will separate the patches.

Thanks
Jin Yao

\
 
 \ /
  Last update: 2017-11-22 02:46    [W:0.106 / U:2.832 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site