lkml.org 
[lkml]   [2017]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] selftest: sync: Use common error handling code in sync_file_info()
From
Date
>> Add a jump target so that a bit of exception handling can be better reused
>> at the end of this function.
>>
>> This issue was detected by using the Coccinelle software.
>
> I would like to see the Coccinelle log included in the commit log

I guess that I can not append the kind of report you might be looking for
so far. This small update suggestion is just another result from one
of my evolving scripts for the semantic patch language.

It was discussed under the topic “Comparing statement lists with SmPL”
to some degree.
https://systeme.lip6.fr/pipermail/cocci/2017-August/004388.html


>> @@ -104,22 +102,23 @@ static struct sync_file_info *sync_file_info(int fd)
>> info->num_fences = num_fences;
>>
>> fence_info = calloc(num_fences, sizeof(*fence_info));
>> - if (!fence_info) {
>> - free(info);
>> - return NULL;
>> - }
>> + if (!fence_info)
>> + goto free_info;
>>
>> info->sync_fence_info = (uint64_t)fence_info;
>>
>> err = ioctl(fd, SYNC_IOC_FILE_INFO, info);
>> if (err < 0) {
>> free(fence_info);
>
> Why not add a free_fence_info to make it consistent?

It did not add another jump label because it would be used only once
for this if branch (according to your enquiry).


>> - free(info);
>> - return NULL;
>> + goto free_info;

Do you expect a second update approach for this source code place?

Regards,
Markus

\
 
 \ /
  Last update: 2017-11-21 19:56    [W:0.039 / U:1.864 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site