lkml.org 
[lkml]   [2017]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] selftests: posix_timers: Use common error handling code in two functions
From
Date
>> Add jump targets so that a bit of exception handling can be better reused
>> at the end of these functions.
>>
>> This issue was detected by using the Coccinelle software.
>
> Please include Coccinelle report in the change log.

I guess that I can not append the kind of report you might be looking for
so far. This small update suggestion is just another result from one
of my evolving scripts for the semantic patch language.

It was discussed under the topic “Comparing statement lists with SmPL”
to some degree.
https://systeme.lip6.fr/pipermail/cocci/2017-August/004388.html


>> @@ -104,10 +104,8 @@ static int check_itimer(int which)
>> signal(SIGALRM, sig_handler);
>>
>> err = gettimeofday(&start, NULL);
>> - if (err < 0) {
>> - perror("Can't call gettimeofday()\n");
>> - return -1;
>> - }
>> + if (err < 0)
>> + goto report_failure;
>
> Instead of report_failure, makes this specific to the failure.
> Something like, gettimeofday_error

Would you like to achieve unique error messages in this use case?

Regards,
Markus

\
 
 \ /
  Last update: 2017-11-21 19:48    [W:0.035 / U:0.296 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site