lkml.org 
[lkml]   [2017]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: phy: harmonize phy_id{,_mask} data type
From
Date
On 11/21/2017 01:52 AM, Richard Leitner wrote:
> From: Richard Leitner <richard.leitner@skidata.com>
>
> Previously phy_id was u32 and phy_id_mask was unsigned int. As the
> phy_id_mask defines the important bits of the phy_id (and is therefore
> the same size) these two variables should be the same data type.
>
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!

> ---
> This patch is extracted from the "net: ethernet: fec: fix refclk enable for SMSC LAN8710/20"
> patch series. This was done because this series will be reworked and
> rebased on not yet merged feature later on. For more details see:
> https://patchwork.ozlabs.org/cover/839468/
> ---
> include/linux/phy.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index dc82a07cb4fd..e00fd9ce3bce 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -509,7 +509,7 @@ struct phy_driver {
> struct mdio_driver_common mdiodrv;
> u32 phy_id;
> char *name;
> - unsigned int phy_id_mask;
> + u32 phy_id_mask;
> u32 features;
> u32 flags;
> const void *driver_data;
>


--
Florian

\
 
 \ /
  Last update: 2017-11-21 18:49    [W:0.044 / U:0.044 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site