lkml.org 
[lkml]   [2017]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] ARM: dts: TS-7970: add basic device tree
From
Date
Hi Fabio,

On 11/20/2017 06:37 PM, Fabio Estevam wrote:
> Hi Sebastien,
>
> On Mon, Nov 20, 2017 at 7:15 PM, Sebastien Bourdelin
> <sebastien.bourdelin@savoirfairelinux.com> wrote:
>
>> +&ecspi2 {
>> + cs-gpios = <
>> + &gpio5 31 GPIO_ACTIVE_HIGH
>> + &gpio7 12 GPIO_ACTIVE_HIGH
>> + &gpio5 18 GPIO_ACTIVE_HIGH
>> + >;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_ecspi2>;
>> + status = "okay";
>> +
>> + spidevfpga: spi@1 {
>> + compatible = "spidev";
>> + reg = <1>;
>> + spi-max-frequency = <1000000>;
>
> According to drivers/spi/spidev.c:
>
> /*
> * spidev should never be referenced in DT without a specific
> * compatible string, it is a Linux implementation thing
> * rather than a description of the hardware.
> */
>

Thanks, you are right!
Just to point it, this warning has been introduced in
956b200a846e324322f6211034c734c65a38e550 in date of march 2015, and it
seems some devices trees whom had been introduced after still use the
"spidev" string only.

\
 
 \ /
  Last update: 2017-11-21 16:38    [W:0.071 / U:25.688 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site