Messages in this thread | | | Subject | Re: [PATCH v2 4/4] drm: omapdrm: Fix DPI on platforms using the DSI VDDS | From | Tomi Valkeinen <> | Date | Tue, 21 Nov 2017 12:25:30 +0200 |
| |
On 16/11/17 10:50, H. Nikolaus Schaller wrote: > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Commit d178e034d565 ("drm: omapdrm: Move FEAT_DPI_USES_VDDS_DSI feature > to dpi code") replaced usage of platform data version with SoC matching > to configure DPI VDDS. The SoC match entries were incorrect, they should > have matched on the machine name instead of the SoC family. Fix it. > > The result was observed on OpenPandora with OMAP3530 where the panel only > had the Blue channel and Red&Green were missing. It was not observed on > GTA04 with DM3730. > > Fixes: d178e034d565 ("drm: omapdrm: Move FEAT_DPI_USES_VDDS_DSI feature to dpi code") > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Reported-by: H. Nikolaus Schaller <hns@goldelico.com> > Tested-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > drivers/gpu/drm/omapdrm/dss/dpi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c b/drivers/gpu/drm/omapdrm/dss/dpi.c > index 4ed5fde11313..a91e5f1a0490 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dpi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dpi.c > @@ -566,8 +566,8 @@ static int dpi_verify_pll(struct dss_pll *pll) > } > > static const struct soc_device_attribute dpi_soc_devices[] = { > - { .family = "OMAP3[456]*" }, > - { .family = "[AD]M37*" }, > + { .machine = "OMAP3[456]*" }, > + { .machine = "[AD]M37*" }, > { /* sentinel */ } > }; > >
I have picked this one. I think the rest of the patches are more of a cleanup, right? And you'll be sending v3 at some point.
Tomi
-- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
| |