[lkml]   [2017]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] drivers/fsi: sbefifo: fix call_kern.cocci warnings
Function sbefifo_enq_xfr called inside lock from sbefifo_write_common but
uses GFP_KERNEL. Change to GFP_ATOMIC.

Generated by: scripts/coccinelle/locks/call_kern.cocci

Fixes: 0f8664fbfc9f ("drivers/fsi: sbefifo: Add miscdevice")
CC: Edward A. James <>
Signed-off-by: Julia Lawall <>
Signed-off-by: Fengguang Wu <>

Semantic patch information:
The proposed change of converting the GFP_KERNEL is not necessarily the
correct one. It may be desired to unlock the lock, or to not call the
function under the lock in the first place.

fsi-sbefifo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/fsi/fsi-sbefifo.c
+++ b/drivers/fsi/fsi-sbefifo.c
@@ -266,7 +266,7 @@ static struct sbefifo_xfr *sbefifo_enq_x
if (READ_ONCE(sbefifo->rc))
return ERR_PTR(sbefifo->rc);

- xfr = kzalloc(sizeof(*xfr), GFP_KERNEL);
+ xfr = kzalloc(sizeof(*xfr), GFP_ATOMIC);
if (!xfr)
return ERR_PTR(-ENOMEM);
 \ /
  Last update: 2017-11-21 07:12    [W:0.025 / U:3.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site