Messages in this thread | | | From | Masahiro Yamada <> | Date | Tue, 21 Nov 2017 12:03:33 +0900 | Subject | Re: [PATCH 1/6] mmc: renesas_sdhc: remove eprobe jump label |
| |
2017-11-21 5:31 GMT+09:00 Wolfram Sang <wsa@the-dreams.de>: > >> - ret = PTR_ERR(priv->clk); >> - dev_err(&pdev->dev, "cannot get clock: %d\n", ret); >> - goto eprobe; >> + dev_err(&pdev->dev, "cannot get clock\n"); >> + return PTR_ERR(priv->clk); > > Why dropping the 'ret' printout? Will it be printed by the core? >
No. I just wanted to save "ret = PTR_ERR(priv->clk)" line.
I will restore the printout as follows:
priv->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(priv->clk)) { ret = PTR_ERR(priv->clk); dev_err(&pdev->dev, "cannot get clock: %d\n", ret); return ret; }
-- Best Regards Masahiro Yamada
| |