Messages in this thread | | | Date | Tue, 21 Nov 2017 01:08:43 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v5 11/11] intel_sgx: driver documentation |
| |
On Sat, Nov 18, 2017 at 12:34:33AM +0100, Thomas Gleixner wrote: > This is architecural. From the cursory read of that series it seems there > are two parts to it: > > 1) The actual core handling, which should be in arch/x86 because that > hardly qualifies as a 'platform' device driver. > > 2) The user space interface, which can be separated out perhaps. > > I don't know how intertwingled they are, but that's hard to tell from the > actual patches w/o doing a deep inspection. Jarkko should be able to answer > that. > > Thanks, > > tglx
Darren, tglx,
You can leave user space device as separate module as sgx_ioctl.c merely calls stuff that I have inside sgx_encl.c. VMA creation is bound to file operations.
My questions would be:
1. What is your recommendation on the deployment under arch/x86? 2. Which parts should be compilable as a LKM? Only the user interface or both parts?
/Jarkko
| |