lkml.org 
[lkml]   [2017]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 17/30] x86, kaiser: map debug IDT tables
On Fri, 10 Nov 2017, Dave Hansen wrote:
>
> +static int kaiser_user_map_ptr_early(const void *start_addr, unsigned long size,
> + unsigned long flags)
> +{
> + int ret = kaiser_add_user_map(start_addr, size, flags);
> + WARN_ON(ret);
> + return ret;

What's the point of the return value when it is ignored at the call site?

> +}
> +
> /*
> * Ensure that the top level of the (shadow) page tables are
> * entirely populated. This ensures that all processes that get
> @@ -374,6 +382,10 @@ void __init kaiser_init(void)
> sizeof(gate_desc) * NR_VECTORS,
> __PAGE_KERNEL_RO | _PAGE_GLOBAL);
>
> + kaiser_user_map_ptr_early(&debug_idt_table,
> + sizeof(gate_desc) * NR_VECTORS,
> + __PAGE_KERNEL | _PAGE_GLOBAL);
> +

Thanks,

tglx

\
 
 \ /
  Last update: 2017-11-20 21:41    [W:0.368 / U:11.756 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site