Messages in this thread | | | Subject | Re: [alsa-devel] [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig | From | Pierre-Louis Bossart <> | Date | Mon, 20 Nov 2017 10:18:01 -0600 |
| |
On 11/18/2017 10:49 AM, Takashi Iwai wrote: > On Sat, 18 Nov 2017 01:01:56 +0100, > Pierre-Louis Bossart wrote: >> +if SND_SOC_INTEL_BAYTRAIL >> >> config SND_SOC_INTEL_BYT_MAX98090_MACH >> tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec" >> + default n > default=n is superfluous, can be dropped. > >> depends on X86_INTEL_LPSS && I2C >> - depends on SND_SST_IPC_ACPI = n >> - depends on SND_SOC_INTEL_BAYTRAIL >> select SND_SOC_MAX98090 > So the dependency on ND_SST_IPC_ACPI=n is removed here too, and I > guess this will allow this machine driver built although it shouldn't > be? This dependency doesn't really make sense any longer at the machine driver level. There is now an explicit layer on the platform side (SND_SOC_INTEL_BAYTRAIL) where the exclusion with SND_SOC_INTEL_HIFI2 platforms should be handled. I also removed this dependency because it was 'one way', I couldn't find a way to show explicit mutual exclusions without getting into circular dependencies.
> > > thanks, > > Takashi > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
| |