lkml.org 
[lkml]   [2017]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: comedi: ni_atmio: fix license warning.
From
Date
On 18/11/17 16:26, Matthew Giassa wrote:
> Resolving license check warning for drivers/staging/comedi. Added the
> license definitions present in the rest of the module and made sure it's
> aligned with the license (GPL) in the comments for the affected file
> (ni_atmio.c). Original warning:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/comedi//drivers/ni_atmio.o
> see include/linux/module.h for more information.
>
> No longer present after change.
>
> Signed-off-by: Matthew Giassa <matthew@giassa.net>
> ---
> drivers/staging/comedi/drivers/ni_atmio.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
> index 2d62a8c..ae6ed96 100644
> --- a/drivers/staging/comedi/drivers/ni_atmio.c
> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
> @@ -361,3 +361,8 @@ static struct comedi_driver ni_atmio_driver = {
> .detach = ni_atmio_detach,
> };
> module_comedi_driver(ni_atmio_driver);
> +
> +MODULE_AUTHOR("Comedi http://www.comedi.org");
> +MODULE_DESCRIPTION("Comedi low-level driver");
> +MODULE_LICENSE("GPL");
> +
>

Thanks. I already reviewed a similar patch for the same driver by Jesse
Chan, but that one never had the MODULE_AUTHOR line. Also, your patch
arrived earlier, so should take precedence.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-

\
 
 \ /
  Last update: 2017-11-20 11:44    [W:0.036 / U:2.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site