lkml.org 
[lkml]   [2017]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] gpu: gma500: remove unneeded DRIVER_LICENSE #define
On Fri, Nov 17, 2017 at 03:50:25PM +0100, Philippe Ombredanne wrote:
> On Fri, Nov 17, 2017 at 3:16 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > There is no need to #define the license of the driver, just put it in
> > the MODULE_LICENSE() line directly as a text string.
> >
> > This allows tools that check that the module license matches the source
> > code license to work properly, as there is no need to unwind the
> > unneeded dereference, especially when the string is defined in a .h file
> > far away from the .c file it is used in.
> >
> > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> > Cc: David Airlie <airlied@linux.ie>
> > Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>

Queued for 4.16, it'll pop up in linux-next as soon as -rc1 is tagged.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

\
 
 \ /
  Last update: 2017-11-20 11:16    [W:0.024 / U:9.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site