Messages in this thread | | | Date | Mon, 20 Nov 2017 11:16:06 +0100 | From | Daniel Vetter <> | Subject | Re: [PATCH] gpu: gma500: remove unneeded DRIVER_LICENSE #define |
| |
On Fri, Nov 17, 2017 at 03:50:25PM +0100, Philippe Ombredanne wrote: > On Fri, Nov 17, 2017 at 3:16 PM, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that the module license matches the source > > code license to work properly, as there is no need to unwind the > > unneeded dereference, especially when the string is defined in a .h file > > far away from the .c file it is used in. > > > > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> > > Cc: David Airlie <airlied@linux.ie> > > Reported-by: Philippe Ombredanne <pombredanne@nexb.com> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Queued for 4.16, it'll pop up in linux-next as soon as -rc1 is tagged. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
| |