Messages in this thread |  | | Date | Mon, 20 Nov 2017 11:13:40 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH 4/6] mmc: sdhci-spear: Handle return value of platform_get_irq |
| |
On 18-11-17, 01:58, Arvind Yadav wrote: > platform_get_irq() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > drivers/mmc/host/sdhci-spear.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c > index 8c0f884..900838b 100644 > --- a/drivers/mmc/host/sdhci-spear.c > +++ b/drivers/mmc/host/sdhci-spear.c > @@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev) > host->hw_name = "sdhci"; > host->ops = &sdhci_pltfm_ops; > host->irq = platform_get_irq(pdev, 0); > + if (host->irq < 0) { > + ret = host->irq; > + goto err_host; > + } > host->quirks = SDHCI_QUIRK_BROKEN_ADMA; > > sdhci = sdhci_priv(host);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
-- viresh
|  |