lkml.org 
[lkml]   [2017]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/mm: Remove unneeded TLB flush for in-place encryption
On Wed, Nov 01, 2017 at 11:54:26AM -0500, Tom Lendacky wrote:
> A TLB flush is not required when doing in-place encryption or decryption
> since the area's pagetable attributes are not being altered. To avoid
> confusion between what the routine is doing and what is documented in
> the AMD APM, delete the local_flush_tlb() call.
>
> Suggested-by: Dave Hansen <dave.hansen@intel.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> arch/x86/mm/mem_encrypt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
> index 16c5f37..53680a9 100644
> --- a/arch/x86/mm/mem_encrypt.c
> +++ b/arch/x86/mm/mem_encrypt.c
> @@ -63,7 +63,6 @@ static void __init __sme_early_enc_dec(resource_size_t paddr,
> if (!sme_me_mask)
> return;
>
> - local_flush_tlb();
> wbinvd();
>
> /*

Reviewed-by: Borislav Petkov <bp@suse.de>

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

\
 
 \ /
  Last update: 2017-11-02 12:53    [W:0.710 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site