Messages in this thread Patch in this message | | | From | Aleksandar Markovic <> | Subject | [PATCH v3 6/8] MIPS: math-emu: Avoid an assignment within if statement condition | Date | Thu, 2 Nov 2017 12:14:03 +0100 |
| |
From: Aleksandar Markovic <aleksandar.markovic@mips.com>
Move invocation of fpu_emu() to be out of if statement condition.
This makes code easier to follow and debug, and fixes a checkpatch warning.
Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com> --- arch/mips/math-emu/cp1emu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/mips/math-emu/cp1emu.c b/arch/mips/math-emu/cp1emu.c index da6c1c0..9e5c880 100644 --- a/arch/mips/math-emu/cp1emu.c +++ b/arch/mips/math-emu/cp1emu.c @@ -1353,7 +1353,8 @@ static int cop1Emulate(struct pt_regs *xcp, struct mips_fpu_struct *ctx, return SIGILL; /* a real fpu computation instruction */ - if ((sig = fpu_emu(xcp, ctx, ir))) + sig = fpu_emu(xcp, ctx, ir); + if (sig) return sig; } break; -- 2.7.4
| |