lkml.org 
[lkml]   [2017]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 2/2] drivers: visorbus: move driver out of staging
    Date
    > -----Original Message-----
    > From: Greg KH [mailto:gregkh@linuxfoundation.org]
    > Sent: Saturday, November 18, 2017 5:26 AM
    > To: Kershner, David A <David.Kershner@unisys.com>
    > Cc: jes.sorensen@gmail.com; linux-kernel@vger.kernel.org; driverdev-
    > devel@linuxdriverproject.org; *S-Par-Maintainer
    > <SParMaintainer@unisys.com>; erik.arfvidson@gmail.com;
    > wadgaonkarsam@gmail.com
    > Subject: Re: [PATCH 2/2] drivers: visorbus: move driver out of staging
    >
    > On Fri, Nov 17, 2017 at 12:27:39PM -0500, David Kershner wrote:
    > > {drivers/staging/unisys/include => include/linux/visorbus}/visorbus.h |
    0
    > > .../staging/unisys/include => include/linux/visorbus}/visorchannel.h |
    0
    >
    > Do we really need two different include/linux .h files for this bus
    > subsystem? Can we merge them both together?
    >

    I will merge them together, they were separate so the other channel
    definitions
    didn't have to include all of visorbus.h for clarity.

    > > diff --git a/drivers/staging/unisys/visorbus/Kconfig
    > b/drivers/visorbus/Kconfig
    > > similarity index 90%
    > > rename from drivers/staging/unisys/visorbus/Kconfig
    > > rename to drivers/visorbus/Kconfig
    > > index 5113880..a99285a 100644
    > > --- a/drivers/staging/unisys/visorbus/Kconfig
    > > +++ b/drivers/visorbus/Kconfig
    > > @@ -4,7 +4,9 @@
    > >
    > > config UNISYS_VISORBUS
    > > tristate "Unisys visorbus driver"
    > > - depends on UNISYSSPAR
    > > + depends on X86_64 && !UML
    > > + select PCI
    > > + select ACPI
    >
    > Wait, what? Why are you messing with the dependancies now? And never
    > do a select if at all possible, do a 'depends on' instead.
    >
    > And why not UML? What about other arches, why are you now restricting
    > it? That's an odd change to be doing here in a "move this out of
    > staging" patch...
    >

    When I moved them out of staging, I noticed that it had "depends on
    UNISYSSPAR"
    flag. The dependencies I added were copied from the UNISYSSPAR dependency
    list.

    I will make a separate patch to switch them over to depends and determine if
    the
    !UML flag is still needed.

    Thanks,
    David Kershner

    > thanks,
    >
    > greg k-h
    [unhandled content-type:application/pkcs7-signature]
    \
     
     \ /
      Last update: 2017-11-18 15:31    [W:6.014 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site