lkml.org 
[lkml]   [2017]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] btrfs: make open_ctree error injectable

* Josef Bacik <josef@toxicpanda.com> wrote:

> From: Josef Bacik <jbacik@fb.com>
>
> This allows us to do error injection with BPF for open_ctree.
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
> ---
> fs/btrfs/disk-io.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index dfdab849037b..c6b4e1f07072 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -31,6 +31,7 @@
> #include <linux/uuid.h>
> #include <linux/semaphore.h>
> #include <asm/unaligned.h>
> +#include <asm/kprobes.h>
> #include "ctree.h"
> #include "disk-io.h"
> #include "hash.h"
> @@ -3283,6 +3284,7 @@ int open_ctree(struct super_block *sb,
> goto fail_block_groups;
> goto retry_root_backup;
> }
> +BPF_ALLOW_ERROR_INJECTION(open_ctree);

Ok, this looks a lot better - except the random header inclusion dependency: if a
facility is in the BPF_*() namespace then it should include <linux/bpf.h> and not
a random asm/* header...

With that detail fixed:

Acked-by: Ingo Molnar <mingo@kernel.org>

for the whole series.

Thanks,

Ingo

\
 
 \ /
  Last update: 2017-11-18 08:06    [W:0.039 / U:2.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site