lkml.org 
[lkml]   [2017]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dmaengine: ioat: Fix error handling path
From
Date


On 11/17/2017 02:37 PM, Christophe JAILLET wrote:
> If the last test in 'ioat_dma_self_test()' fails, we must release all
> the allocated resources and not just part of them.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Good catch! Thanks! Acked-by: Dave Jiang <dave.jiang@intel.com>

> ---
> drivers/dma/ioat/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> index 2f31d3d0caa6..7792a9186f9c 100644
> --- a/drivers/dma/ioat/init.c
> +++ b/drivers/dma/ioat/init.c
> @@ -390,7 +390,7 @@ static int ioat_dma_self_test(struct ioatdma_device *ioat_dma)
> if (memcmp(src, dest, IOAT_TEST_SIZE)) {
> dev_err(dev, "Self-test copy failed compare, disabling\n");
> err = -ENODEV;
> - goto free_resources;
> + goto unmap_dma;
> }
>
> unmap_dma:
>

\
 
 \ /
  Last update: 2017-11-17 22:45    [W:0.042 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site