lkml.org 
[lkml]   [2017]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/10] Input: sirfsoc-onkey: Handle return value of platform_get_irq
On Sat, Nov 18, 2017 at 12:45:31AM +0530, Arvind Yadav wrote:
> platform_get_irq() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied, thank you.

> ---
> drivers/input/misc/sirfsoc-onkey.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/input/misc/sirfsoc-onkey.c b/drivers/input/misc/sirfsoc-onkey.c
> index 4fd038d..de04b48 100644
> --- a/drivers/input/misc/sirfsoc-onkey.c
> +++ b/drivers/input/misc/sirfsoc-onkey.c
> @@ -149,6 +149,9 @@ static int sirfsoc_pwrc_probe(struct platform_device *pdev)
> sirfsoc_pwrc_toggle_interrupts(pwrcdrv, false);
>
> irq = platform_get_irq(pdev, 0);
> + if (irq < 0)
> + return irq;
> +
> error = devm_request_irq(&pdev->dev, irq,
> sirfsoc_pwrc_isr, 0,
> "sirfsoc_pwrc_int", pwrcdrv);
> --
> 2.7.4
>

--
Dmitry

\
 
 \ /
  Last update: 2017-11-17 20:59    [W:0.189 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site