lkml.org 
[lkml]   [2017]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/10] Input: omap4-keypad: Fix platform_get_irq's error checking
    Date
    The platform_get_irq() function returns negative if an error occurs.
    zero or positive number on success. platform_get_irq() error checking
    for zero is not correct.

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    ---
    drivers/input/keyboard/omap4-keypad.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c
    index 940d38b..8a4b161 100644
    --- a/drivers/input/keyboard/omap4-keypad.c
    +++ b/drivers/input/keyboard/omap4-keypad.c
    @@ -251,7 +251,7 @@ static int omap4_keypad_probe(struct platform_device *pdev)
    }

    irq = platform_get_irq(pdev, 0);
    - if (!irq) {
    + if (irq < 0) {
    dev_err(&pdev->dev, "no keyboard irq assigned\n");
    return -EINVAL;
    }
    --
    2.7.4
    \
     
     \ /
      Last update: 2017-11-17 20:16    [W:4.322 / U:0.580 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site