lkml.org 
[lkml]   [2017]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] mm: filemap: remove include of hardirq.h
From
Date
Hi folks,

Any comment on this patch? The quick build test passed on the latest
Linus's tree.

Thanks,
Yang


On 11/6/17 8:21 AM, Yang Shi wrote:
> in_atomic() has been moved to include/linux/preempt.h, and the filemap.c
> doesn't use in_atomic() directly at all, so it sounds unnecessary to
> include hardirq.h.
>
> Signed-off-by: Yang Shi <yang.s@alibaba-inc.com>
> ---
> v1 --> v2:
> * Removed the wrong message about kernel size change
>
> mm/filemap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 594d73f..57238f4 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -31,7 +31,6 @@
> #include <linux/blkdev.h>
> #include <linux/security.h>
> #include <linux/cpuset.h>
> -#include <linux/hardirq.h> /* for BUG_ON(!in_atomic()) only */
> #include <linux/hugetlb.h>
> #include <linux/memcontrol.h>
> #include <linux/cleancache.h>
>

\
 
 \ /
  Last update: 2017-11-17 18:59    [W:0.060 / U:0.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site