Messages in this thread |  | | From | Philippe Ombredanne <> | Date | Fri, 17 Nov 2017 15:53:49 +0100 | Subject | Re: [PATCH] ntb: remove unneeded DRIVER_LICENSE #defines |
| |
On Fri, Nov 17, 2017 at 3:20 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source > code license to work properly, as there is no need to unwind the > unneeded dereference, especially when the string is defined just a few > lines above the usage of it. > > Cc: Jon Mason <jdmason@kudzu.us> > Cc: Dave Jiang <dave.jiang@intel.com> > Cc: Allen Hubbe <Allen.Hubbe@emc.com> > Cc: Gary R Hook <gary.hook@amd.com> > Cc: Serge Semin <fancer.lancer@gmail.com> > Reported-by: Philippe Ombredanne <pombredanne@nexb.com> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com> -- Cordially Philippe Ombredanne
|  |