lkml.org 
[lkml]   [2017]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/5] ARM64: dts: meson-axg: add I2C DT info for Meson-AXG SoC
From
Date
Hi Yixun, Jian,

On 17/11/2017 09:02, Yixun Lan wrote:
> From: Jian Hu <jian.hu@amlogic.com>
>
> There are four I2C masters in EE domain, and one I2C Master in
> AO domain, the DT info here should describe them all.
>
> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 59 ++++++++++++++++++++++++++++++
> 1 file changed, 59 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 57faaa9d8013..99e967aff439 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -129,6 +129,54 @@
> #reset-cells = <1>;
> };
>
> + i2c_m0: i2c@1f000 {

Can you use a more simple "i2c0" phandle naming instead ? or get back to the "i2c_A/B/C/D" naming like in meson_gx to keep consistency ?

[...]

> + };
> +
> + i2c_m1: i2c@1e000 {

[...]

> + };
> +
> + i2c_m2: i2c@1d000 {

[...]

> + };
> +
> + i2c_m3: i2c@1c000 {

[...]

> + };
> +
> uart_A: serial@24000 {
> compatible = "amlogic,meson-gx-uart", "amlogic,meson-uart";
> reg = <0x0 0x24000 0x0 0x14>;
> @@ -312,6 +360,17 @@
> };
> };
>
> + i2c_ao: i2c@5000 {

Can you keep the same "i2c_AO" as in meson-gx ?


[...]

> + };
> +
> uart_AO: serial@3000 {
> compatible = "amlogic,meson-gx-uart", "amlogic,meson-ao-uart";
> reg = <0x0 0x3000 0x0 0x18>;
>

Neil

\
 
 \ /
  Last update: 2017-11-17 17:19    [W:0.196 / U:27.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site