lkml.org 
[lkml]   [2017]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ASoC: Intel: Add defaults for SND_SST_ options and machine drivers
On Thu, Nov 16, 2017 at 2:16 PM, Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
> Add 'default m' when sensible

No.

This is not sensible, and is not at all what I suggested.

Actual new code should *never* be default 'm' or 'y'.

You may think it's supremely important because you maintain it, but so
does EVERY other developer for their code, and no, we don'[t want to
just default everything on.

So the only thing that should be on by default is stuff that either

(a) is a new option for something that used to not have an option at
all and was always enabled

IOW, this is a "it used to always be there, we default it on now
that we've made it optional".

(b) stuff that doesn't actually generate any code, but is there as a choice.

So this is stuff like "show me the config options for vendor XYZ".

(c) stuff that really is so common that it is the majority of users.

This is stuff like USB, or block devices, or "enable networking".

But some individual driver for some hardware that nobody has? No.

So things like this is pure garbage:

config SND_SST_ATOM_HIFI2_PLATFORM
tristate "Intel ASoC SST driver for HiFi2 platforms
(*field, *trail)"
default m

because clearly "Intel ASoC SST driver for HiFi2 platforms" should not
at all default to being on for everybody.

So NAK NAK NAK on stuff like this.

Linus
\
 
 \ /
  Last update: 2017-11-17 17:18    [W:0.057 / U:9.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site