lkml.org 
[lkml]   [2017]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 25/28] brcmfmac: remove setting IBSS mode when stopping AP
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Chi-hsien Lin <Chi-Hsien.Lin@cypress.com>

    commit 9029679f66d976f8c720eb03c4898274803c9923 upstream.

    Upon stopping an AP interface the driver disable INFRA mode effectively
    setting the interface in IBSS mode. However, this may affect other
    interfaces running in INFRA mode. For instance, if user creates and stops
    hostap daemon on virtual interface, then association cannot work on
    primary interface because default BSS has been set to IBSS mode in
    firmware side. The IBSS mode should be set when cfg80211 changes the
    interface.

    Reviewed-by: Wright Feng <wright.feng@cypress.com>
    Signed-off-by: Chi-hsien Lin <Chi-Hsien.Lin@cypress.com>
    [kvalo@codeaurora.org: rephased commit log based on discussion]
    Signed-off-by: Wright Feng <wright.feng@cypress.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Cc: Philipp Rosenberger <p.rosenberger@linutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c | 3 ---
    1 file changed, 3 deletions(-)

    --- a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
    +++ b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c
    @@ -4295,9 +4295,6 @@ static int brcmf_cfg80211_stop_ap(struct
    err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_SET_AP, 0);
    if (err < 0)
    brcmf_err("setting AP mode failed %d\n", err);
    - err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_SET_INFRA, 0);
    - if (err < 0)
    - brcmf_err("setting INFRA mode failed %d\n", err);
    if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_MBSS))
    brcmf_fil_iovar_int_set(ifp, "mbss", 0);
    err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_SET_REGULATORY,

    \
     
     \ /
      Last update: 2017-11-17 17:18    [W:4.222 / U:0.592 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site