lkml.org 
[lkml]   [2017]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.13 22/44] net/unix: dont show information about sockets from other namespaces
    Date
    4.13-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Andrei Vagin <avagin@openvz.org>


    [ Upstream commit 0f5da659d8f1810f44de14acf2c80cd6499623a0 ]

    socket_diag shows information only about sockets from a namespace where
    a diag socket lives.

    But if we request information about one unix socket, the kernel don't
    check that its netns is matched with a diag socket namespace, so any
    user can get information about any unix socket in a system. This looks
    like a bug.

    v2: add a Fixes tag

    Fixes: 51d7cccf0723 ("net: make sock diag per-namespace")
    Signed-off-by: Andrei Vagin <avagin@openvz.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/unix/diag.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/net/unix/diag.c
    +++ b/net/unix/diag.c
    @@ -257,6 +257,8 @@ static int unix_diag_get_exact(struct sk
    err = -ENOENT;
    if (sk == NULL)
    goto out_nosk;
    + if (!net_eq(sock_net(sk), net))
    + goto out;

    err = sock_diag_check_cookie(sk, req->udiag_cookie);
    if (err)

    \
     
     \ /
      Last update: 2017-11-17 17:18    [W:4.324 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site