Messages in this thread | | | Date | Wed, 15 Nov 2017 23:10:27 -0600 | From | Rob Herring <> | Subject | Re: [PATCH] of/pci: Fix theoretical NULL dereference |
| |
On Wed, Nov 15, 2017 at 12:50:06PM +0000, Robin Murphy wrote: > In the (relatively mechanical) process of adapting the RID-mapping code > to put the resulting ID in an output argument rather than the funtion > return value, we ended up with the debug print using the argument > pointer rather than the local value, which potentially defeats the > earlier NULL check. > > Fixes: 987068fcbdb7: "of/irq: Break out msi-map lookup (again)" > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Robin Murphy <robin.murphy@arm.com> > --- > drivers/of/of_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Applied.
Rob
| |