lkml.org 
[lkml]   [2017]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v7 10/13] dt-bindings: Add qcom slimbus controller bindings
From
Date
Thanks for the review,

On 16/11/17 05:19, Rob Herring wrote:
>> + entry should be used.
>> + - reg-name for slew rate: "slew"
> reg-names
>
> I'd prefer it be explicit as to which compatibles do or don't have this
> register.
Makes sense, I will take this in before sending next version.
>
>> +
>> +Example:
>> +
>> + slim@28080000 {
>> + compatible = "qcom,apq8064-slim", "qcom,slim";
>> + reg = <0x28080000 0x2000>,
> error ^
>
thanks for spotting.. will fix this.
>> + interrupts = <0 33 0>;
>> + clocks = <&lcc SLIMBUS_SRC>, <&lcc AUDIO_SLIMBUS_CLK>;
>> + clock-names = "iface", "core";
>> + #address-cells = <2>;
>> + #size-cell = <0>;
>> +
>> + codec: wcd9310@1,0{
> Use generic node names:
>
> wcd9310: audio-codec@1,0
Yep, will do that.

thanks,
srini
>

\
 
 \ /
  Last update: 2017-11-16 10:43    [W:0.195 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site