lkml.org 
[lkml]   [2017]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/12] isdn: hisax: Fix pnp_irq's error checking for setup_ix1micro
    Date
    The pnp_irq() function returns -1 if an error occurs.
    pnp_irq() error checking for zero is not correct.

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    ---
    drivers/isdn/hisax/ix1_micro.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/isdn/hisax/ix1_micro.c b/drivers/isdn/hisax/ix1_micro.c
    index 7ae39f5..bfb79f3 100644
    --- a/drivers/isdn/hisax/ix1_micro.c
    +++ b/drivers/isdn/hisax/ix1_micro.c
    @@ -256,7 +256,7 @@ int setup_ix1micro(struct IsdnCard *card)
    }
    card->para[1] = pnp_port_start(pnp_d, 0);
    card->para[0] = pnp_irq(pnp_d, 0);
    - if (!card->para[0] || !card->para[1]) {
    + if (card->para[0] == -1 || !card->para[1]) {
    printk(KERN_ERR "ITK PnP:some resources are missing %ld/%lx\n",
    card->para[0], card->para[1]);
    pnp_disable_dev(pnp_d);
    --
    1.9.1
    \
     
     \ /
      Last update: 2017-11-16 05:31    [W:2.754 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site