lkml.org 
[lkml]   [2017]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86,kvm: move qemu/guest FPU switching out to vcpu_run
From
Date
On 14/11/2017 20:40, David Hildenbrand wrote:
> I think we should check all get/put_fpu callers if they need
> preempt_disable().
>
> E.g. em_fxrstor() needs disabled preemption as we temporarily
> save + restore some host register (via fxsave + fxrstor) under some
> circumstances that are not saved/restored when switching to/back from
> another process. We should double check.

Rik may correct me, but I believe that you don't need
preempt_disable/enable because preempt notifiers do this for you.

Paolo

\
 
 \ /
  Last update: 2017-11-15 09:35    [W:1.084 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site