Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 14 Nov 2017 16:00:00 -0800 | Subject | Re: [GIT pull] printk updates for 4.15 |
| |
On Tue, Nov 14, 2017 at 2:50 PM, Thomas Gleixner <tglx@linutronix.de> wrote: > +/* > + * struct timestanps - Simultaneous mono/boot/real timestamps > + * @mono: Monotonic timestamp > + * @boot: Boottime timestamp > + * @real: Realtime timestamp > + */
Side note: does anybody really wanr/need the boottime thing?
I can definitely understand why people want a monotonic clock (since ordering is meaningful). And at the same time, it's pretty obvious that wall clock is meaningful.
Who really wants that boot time thing when you have those two? I get the feeling hat nobody really wanted it, and it was just added for completeness.
I don't think 'struct printk_log' is _that_ size sensitive, but it does seem to be a bad idea to add 8 bytes without having a good reason for it. The other times seem to have good reasons, not so much the boot one.
Linus
| |