Messages in this thread | | | From | Masahiro Yamada <> | Date | Tue, 14 Nov 2017 20:13:43 +0900 | Subject | Re: [PATCH v3] coccinelle: fix parallel build with CHECK=scripts/coccicheck |
| |
2017-11-14 20:09 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>: > > > On Tue, 14 Nov 2017, Masahiro Yamada wrote: > >> Hi Julia, >> >> >> 2017-11-14 18:49 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>: >> >> + >> >> + # If -j option is given to Make, scripts/coccicheck runs in parallel. >> >> + # If coccinelle also runs in parallel, it fails because multiple processes >> >> + # try to get access to the same subdirectory that stores stdout/stderr. >> >> + # No need to parallelize coccinelle in this case - this mode takes only >> >> + # one file input. >> >> + NPROC=1 >> > >> > Since I am also changing Coccinelle to avoid the problem, maybe it would >> > be better to just remove the explanation sentence (If coccinelle also runs >> > in parallel,...). >> > >> > julia >> >> OK. Which lines are unneeded? >> >> Is it OK to remove all the comments, then just add "NPROC=1"? > > How about keeping "# No need to parallelize coccinelle in this case - this > mode takes only one file input."?
Fair enough.
I will send v4 shortly.
> But if you think it is obvious, it would be ok to remove it also. Someone > can always do git blame and read the commit message if they have > questions. > > julia > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Best Regards Masahiro Yamada
| |