Messages in this thread | | | Subject | Re: [PATCH] IB/qib: remove redundant setting of any in for-loop | From | Doug Ledford <> | Date | Mon, 13 Nov 2017 16:52:58 -0500 |
| |
On Fri, 2017-11-10 at 19:07 +0000, Marciniszyn, Mike wrote: > > > On Fri, 2017-10-20 at 09:21 +0200, Colin King wrote: > > > > From: Colin Ian King <colin.king@canonical.com> > > > > > > > > The variable all is being set but is never read after this > > > > hence it can be removed from the for loop initialization. > > > > Cleans up clang warning: > > > > > > any is really used as bool and is initialized at function > > > entry. The earlier loop also reinitializes any unnecessarily. > > > > Denny, can you weigh in on what you want in this thread? Thanks. > > > > I am ok with both Colin's and Joe's patch. > > Joe's patch would require additional testing vs. the trivial warning fix. > > Then there is a "guideline" to keep fixes separate from clean up... > > Doug, do you want a tested patch from me?
Preferably, yes :-)
-- Doug Ledford <dledford@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD[unhandled content-type:application/pgp-signature] | |