Messages in this thread | | | Date | Mon, 13 Nov 2017 10:49:03 -0800 | From | Tony Lindgren <> | Subject | Re: [PATCH] iio: adc: cpcap: fix incorrect validation |
| |
* Sebastian Reichel <sre@kernel.org> [171112 18:30]: > Hi, > > On Mon, Nov 13, 2017 at 12:01:20AM +0800, Pan Bian wrote: > > Function platform_get_irq_byname() returns a negative error code on > > failure, and a zero or positive number on success. However, in function > > cpcap_adc_probe(), positive IRQ numbers are also taken as error cases. > > Use "if (ddata->irq < 0)" instead of "if (!ddata->irq)" to validate the > > return value of platform_get_irq_byname(). > > > > Signed-off-by: Pan Bian <bianpan2016@163.com> > > --- > > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Acked-by: Tony Lindgren <tony@atomide.com>
| |