Messages in this thread |  | | Date | Mon, 13 Nov 2017 21:30:29 +0300 | | From | Dan Carpenter <> | | Subject | Re: [PATCH 1/4] ALSA: cs46xx: Adjust 33 function calls together with a variable assignment |
| |
On Mon, Nov 13, 2017 at 07:22:30PM +0100, SF Markus Elfring wrote: > - > - if ( (cpcm->pcm_channel = cs46xx_dsp_create_pcm_channel (chip, sample_rate, cpcm, > - cpcm->hw_buf.addr, > - cpcm->pcm_channel_id)) == NULL) { > + cpcm > + ->pcm_channel = cs46xx_dsp_create_pcm_channel(chip, ^^^^^^^^^^^^^ Please don't break it up like this
> + sample_rate, > + cpcm, > + cpcm->hw_buf.addr, > + cpcm > + ->pcm_channel_id); ^^^^^^^^^^^^^^^^ or this. It's better to go over 80 characters than to do that.
regards, dan carpenter
|  |