lkml.org 
[lkml]   [2017]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: adc: cpcap: fix incorrect validation
Hi,

On Mon, Nov 13, 2017 at 12:01:20AM +0800, Pan Bian wrote:
> Function platform_get_irq_byname() returns a negative error code on
> failure, and a zero or positive number on success. However, in function
> cpcap_adc_probe(), positive IRQ numbers are also taken as error cases.
> Use "if (ddata->irq < 0)" instead of "if (!ddata->irq)" to validate the
> return value of platform_get_irq_byname().
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

> drivers/iio/adc/cpcap-adc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/cpcap-adc.c b/drivers/iio/adc/cpcap-adc.c
> index 6e419d5..f153e026 100644
> --- a/drivers/iio/adc/cpcap-adc.c
> +++ b/drivers/iio/adc/cpcap-adc.c
> @@ -1012,7 +1012,7 @@ static int cpcap_adc_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, indio_dev);
>
> ddata->irq = platform_get_irq_byname(pdev, "adcdone");
> - if (!ddata->irq)
> + if (ddata->irq < 0)
> return -ENODEV;
>
> error = devm_request_threaded_irq(&pdev->dev, ddata->irq, NULL,
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-11-12 19:29    [W:0.046 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site