lkml.org 
[lkml]   [2017]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] net: thunderx: fix double free error
From
From: Aleksey Makarov <aleksey.makarov@cavium.com>
Date: Thu, 9 Nov 2017 14:58:57 +0300

> This patch fixes an error in memory allocation/freeing in
> ThunderX PF driver.
>
> I moved the allocation to the probe() function and made it managed.
>
> From the Colin's email:
>
> While running static analysis on linux-next with CoverityScan I found 3
> double free errors in the Cavium thunder driver.
>
> The issue occurs on the err_disable_device: label of function nic_probe
> when nic_free_lmacmem(nic) is called and a double free occurs on
> nic->duplex, nic->link and nic->speed. This occurs when nic_init_hw()
> fails:
>
> /* Initialize hardware */
> err = nic_init_hw(nic);
> if (err)
> goto err_release_regions;
>
> nic_init_hw() calls nic_get_hw_info() and this calls nic_free_lmacmem()
> if any of the allocations fail. This free'ing occurs again by the call
> to nic_free_lmacmem() on the err_release_regions exit path in nic_probe().
>
> Reported-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Aleksey Makarov <aleksey.makarov@cavium.com>

Applied, thank you.

\
 
 \ /
  Last update: 2017-11-11 11:23    [W:0.033 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site