Messages in this thread | | | Subject | Re: [PATCH 04/14] nubus: Fix log spam | From | Joe Perches <> | Date | Sat, 11 Nov 2017 16:08:33 -0800 |
| |
On Sun, 2017-11-12 at 10:47 +1100, Finn Thain wrote: > On Sat, 11 Nov 2017, Joe Perches wrote: > > > On Sat, 2017-11-11 at 01:12 -0500, Finn Thain wrote: > > > Testing shows that a single Radius PrecisionColor 24X display board, > > > which has 95 functional resources, produces over a thousand lines of > > > log messages. Suppress these messages with pr_debug(). > > > Remove some redundant messages relating to nubus_get_subdir() calls. > > > Fix the format block debug messages which has the sequence of entries > > > backwards (my bad). > > > Move the "Scanning slots" message to its proper location. > > > > pr_debug calls are compiled completely away to nothing > > unless DEBUG is > > defined or CONFIG_DYNAMIC_DEBUG is > > enabled. > > > > Aren't some of these actually useful? > > > > No, not AFAIK. Was there anything in particular that you wanted to see in > the log?
I don't have any of these and I only glanced at the code, so if it's unimportant, then that's fine.
The only one I saw as remotely useful was the MAC address.
> > Perhaps it'd be nicer to have some nubus > > specific flag to enable these outputs instead > > of relying on either #define DEBUG or > > CONFIG_DYNAMIC_DEBUG? > > > > The file /proc/nubus has the important info. These patches don't affect > that. For example, > > # cat /proc/nubus > Nubus devices found: > Slot E: Farallon EtherMac LC-TP > #
Anyway maybe use nubus_debug and allow that to be something like:
#ifdef CONFIG_NUBUS_DEBUG #define DEBUG #endif
#define nubus_debug pr_debug
or
and maybe allow some module param to control it
MODULE_PARM_DESC(nubus_init_loggging, "Enable nubus init debug logging - set to 1 to enable");
#define nubus_debug(fmt, ...) \ do { \ if (nubus_init_logging) \ printk(KERN_DEBUG fmt, ##__VA_ARGS__); \ } while (0)
Just suggestions. Use or ignore.
cheers, Joe
| |