lkml.org 
[lkml]   [2017]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4.4 34/46] crypto: xts - Add ECB dependency
From
Date
On Thu, 2017-10-19 at 15:49 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me
> know.
>
> ------------------
>
> From: Milan Broz <gmazyland@gmail.com>
>
>
> [ Upstream commit 12cb3a1c4184f891d965d1f39f8cfcc9ef617647 ]
>
> Since the
>    commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40
>    crypto: xts - Convert to skcipher

That commit went into 4.10, and not any stable branches. So this fix
doesn't appear to be appropriate for the older branches it was applied
to.

Ben.

> the XTS mode is based on ECB, so the mode must select
> ECB otherwise it can fail to initialize.
>
> Signed-off-by: Milan Broz <gmazyland@gmail.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  crypto/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -343,6 +343,7 @@ config CRYPTO_XTS
>   select CRYPTO_BLKCIPHER
>   select CRYPTO_MANAGER
>   select CRYPTO_GF128MUL
> + select CRYPTO_ECB
>   help
>     XTS: IEEE1619/D16 narrow block cipher use with aes-xts-
> plain,
>     key size 256, 384 or 512 bits. This implementation
> currently
>
>
>
--
Ben Hutchings
Software Developer, Codethink Ltd.

\
 
 \ /
  Last update: 2017-11-10 21:42    [W:0.168 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site