[lkml]   [2017]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net-next 0/2] net: dsa: lan9303: IGMP handling

Den 10. nov. 2017 15:07, skrev Andrew Lunn:
>> skb->offload_fwd_mark calculation is a candidate for consolidation into the
>> DSA core. The calculation can probably be more polished when done at a point
>> where DSA has updated skb.
> Hi Egil
> Yes, at some point we should do this. But at the moment it is too
> early. We don't have enough experience with what the different
> switches need. I would like to see 4 or more devices doing it before
> we consolidate the code into the core.

Absolutely. My point was rather I prefer not spend time polishing this
snippet right now, because it will probably be refactored later anyway.

One steppingstone could be to make reusable helper-functions in
net/dsa/dsa_priv.h. But I leave that to device #2 that implement this ;-)

> Andrew


 \ /
  Last update: 2017-11-10 19:23    [W:0.069 / U:7.808 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site