lkml.org 
[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: android: ion: remove redundant variable table
From
Date
On 10/31/2017 07:02 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable table is being set but is never read, it is therefore
> redundant and can be removed. Cleans up clang warning:
>
> drivers/staging/android/ion/ion.c:112:2: warning: Value stored to 'table' is never read
>

Acked-by: Laura Abbott <labbott@redhat.com>

> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/android/ion/ion.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 93e2c90fa77d..a7d9b0e98572 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -81,7 +81,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
> unsigned long flags)
> {
> struct ion_buffer *buffer;
> - struct sg_table *table;
> int ret;
>
> buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
> @@ -109,7 +108,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
> goto err1;
> }
>
> - table = buffer->sg_table;
> buffer->dev = dev;
> buffer->size = len;
>
>

\
 
 \ /
  Last update: 2017-11-02 00:10    [W:0.028 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site