lkml.org 
[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 02/23] x86, kaiser: do not set _PAGE_USER for init_mm page tables
    On Wed, Nov 1, 2017 at 2:52 PM, Dave Hansen <dave.hansen@linux.intel.com> wrote:
    > On 11/01/2017 02:28 PM, Thomas Gleixner wrote:
    >> On Wed, 1 Nov 2017, Andy Lutomirski wrote:
    >>> The vsyscall page is _PAGE_USER and lives in init_mm via the fixmap.
    >>
    >> Groan, forgot about that abomination, but still there is no point in having
    >> it marked PAGE_USER in the init_mm at all, kaiser or not.
    >
    > So shouldn't this patch effectively make the vsyscall page unusable?
    > Any idea why that didn't show up in any of the x86 selftests?

    I actually think there may be two issues here:

    - vsyscall isn't even used much - if any - any more

    - the vsyscall emulation works fine without _PAGE_USER, since the
    whole point is that we take a fault on it and then emulate.

    We do expose the vsyscall page read-only to user space in the
    emulation case, but I'm not convinced that's even required.

    Nobody who configures KAISER enabled would possibly want to have the
    actual native vsyscall page enabled. That would be an insane
    combination.

    So the only possibly difference would be a user mode program that
    actually looks at the vsyscall page, which sounds unlikely to be an
    issue. It's legacy and not really used.

    Linus

    \
     
     \ /
      Last update: 2017-11-01 23:13    [W:4.135 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site