lkml.org 
[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 029/139] vt: fix unchecked __put_user() in tioclinux ioctls
    Date
    From: Adam Borowski <kilobyte@angband.pl>

    commit 6987dc8a70976561d22450b5858fc9767788cc1c upstream.

    Only read access is checked before this call.

    Actually, at the moment this is not an issue, as every in-tree arch does
    the same manual checks for VERIFY_READ vs VERIFY_WRITE, relying on the MMU
    to tell them apart, but this wasn't the case in the past and may happen
    again on some odd arch in the future.

    If anyone cares about 3.7 and earlier, this is a security hole (untested)
    on real 80386 CPUs.

    Signed-off-by: Adam Borowski <kilobyte@angband.pl>
    CC: stable@vger.kernel.org # v3.7-
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/tty/vt/vt.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
    index 010ec70..3390a39 100644
    --- a/drivers/tty/vt/vt.c
    +++ b/drivers/tty/vt/vt.c
    @@ -2601,13 +2601,13 @@ int tioclinux(struct tty_struct *tty, unsigned long arg)
    * related to the kernel should not use this.
    */
    data = vt_get_shift_state();
    - ret = __put_user(data, p);
    + ret = put_user(data, p);
    break;
    case TIOCL_GETMOUSEREPORTING:
    console_lock(); /* May be overkill */
    data = mouse_reporting();
    console_unlock();
    - ret = __put_user(data, p);
    + ret = put_user(data, p);
    break;
    case TIOCL_SETVESABLANK:
    console_lock();
    @@ -2616,7 +2616,7 @@ int tioclinux(struct tty_struct *tty, unsigned long arg)
    break;
    case TIOCL_GETKMSGREDIRECT:
    data = vt_get_kmsg_redirect();
    - ret = __put_user(data, p);
    + ret = put_user(data, p);
    break;
    case TIOCL_SETKMSGREDIRECT:
    if (!capable(CAP_SYS_ADMIN)) {
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-11-01 22:57    [W:4.464 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site