lkml.org 
[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/23] x86, kaiser: prepare assembly for entry/exit CR3 switching
On Tue, 31 Oct 2017, Dave Hansen wrote:
>
> + pushq %rdi
> + SWITCH_TO_KERNEL_CR3 scratch_reg=%rdi
> + popq %rdi

Can you please have a macro variant which does:

SWITCH_TO_KERNEL_CR3_PUSH reg=%rdi

So the pushq/popq is inside the macro. This has two reasons:

1) If KAISER=n the pointless pushq/popq go away

2) We need a boottime switch for that stuff, so we better have all
related code in the various macros in order to patch it in/out.

Also, please wrap these macros in #ifdef KAISER right away and provide the
stubs as well. It does not make sense to have them in patch 7 when patch 1
introduces them.

Aside of Boris comments this looks about right.

Thanks,

tglx

\
 
 \ /
  Last update: 2017-11-01 22:02    [W:0.215 / U:0.292 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site