lkml.org 
[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] hv: kvp: Avoid reading past allocated blocks from KVP file
Date
> From: Greg KH [mailto:greg@kroah.com]
> Sent: Tuesday, October 31, 2017 11:50 PM
> To: Long Li <longli@microsoft.com>
> Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; Stephen Hemminger
> <sthemmin@microsoft.com>; devel@linuxdriverproject.org; linux-
> kernel@vger.kernel.org; stable@vger.kernel.org; Paul Meyer
> <Paul.Meyer@microsoft.com>; Long Li <longli@microsoft.com>
> Subject: Re: [PATCH v2] hv: kvp: Avoid reading past allocated blocks from
> KVP file
>
> On Tue, Oct 31, 2017 at 01:02:35PM -0700, Long Li wrote:
> > From: Paul Meyer <Paul.Meyer@microsoft.com>
> >
> > While reading in more than one block (50) of KVP records, the
> > allocation goes per block, but the reads used the total number of
> > allocated records (without resetting the pointer/stream). This causes
> > the records buffer to overrun when the refresh reads more than one
> > block over the previous capacity (e.g. reading more than 100 KVP
> > records whereas the in-memory database was empty before).
> >
> > Fix this by reading the correct number of KVP records from file each time.
> >
> > Signed-off-by: Paul Meyer <Paul.Meyer@microsoft.com>
> > Signed-off-by: Long Li <longli@microsoft.com>
> > ---
> > tools/hv/hv_kvp_daemon.c | 66
> > ++++++++----------------------------------------
> > 1 file changed, 10 insertions(+), 56 deletions(-)
>
> When you version a patch, you always have to say what changed below the
> --- line, as the documentation states to do...

Sorry it was my bad. Can I resend v2 and indicate what has changed?

Long

>
> v3? :)
>
> thanks,
>
> greg k-h

\
 
 \ /
  Last update: 2017-11-01 19:40    [W:0.050 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site