[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH v11 14/15] platform/x86: dell-smbios-wmi: introduce userspace interface
> > +/* This structure may be modified by the firmware when we enter
> > + * system management mode through SMM, hence the volatiles
> > + */
> > +struct calling_interface_buffer {
> > + __u16 class;
> Hey Mario,
> I just realized that there is a slight problem calling this identifier
> "class" for userspace that happens to be written in C++ that #includes
> this header as class is a reversed word.
> Perhaps we could rename it to class_ or something otherwise userspace
> has to shim with a C object and extern it with new identifiers to the
> C++ component, which is awkward.


Ah darn, I wish we would have caught this earlier in the series development,
but it's better to do fix it now rather than after the uapi has been included in
a kernel.


I think I should adjust the series for this change to
s/class/cmd_class; s/select/cmd_select/
As ->class is used in many patches in the series, it will require be better to
resend as v12 rather than a single patch that changes this one thing.

I'll send it later this afternoon.


 \ /
  Last update: 2017-11-01 17:16    [W:0.097 / U:8.576 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site