lkml.org 
[lkml]   [2017]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths
On Wed, Nov 01, 2017 at 04:29:21AM -0700, Andy Lutomirski wrote:
> I'm inclined to leave it. I first wrote it without the long name and
> then I had to re-read the code to make sure I got the register state
> right. The long name serves as documentation that we need rcx and r11
> to have special contents. There's only one place that jumps there and
> it's in the same function.

Frankly, I'd prefer a sane label name and a good comment over it instead
of insanely long label name which is not as explanatory as a normal
english sentence or two.

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

\
 
 \ /
  Last update: 2017-11-01 13:35    [W:0.094 / U:7.252 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site